fix: correct partition field handling for non-partitioned tables and add test for manifest file reader #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeartLinked
commented
Aug 14, 2025
HeartLinked
commented
- Fix ManifestEntry::operator== logic with proper parentheses grouping
- Add null pointer safety in DataFile::Type() for non-partitioned tables
- Change partition field type validation from list to struct in manifest reader
- Support empty partition structs for non-partitioned tables (n_children == 0)
- Update unit test for manifest file: separate v1 and v2 test, and add another v2 test for non-partitioned tables
HeartLinked
force-pushed
the
manifest-reader-v2-fixes
branch
from
8db6621 to
76994af
Compare
HeartLinked
changed the title
- Add V2NonPartitionedBasicTest to test manifest reader v2 functionality - Fix bounds values to match actual manifest file data - Use proper C++23 designated initializers for test data setup
- Fix ManifestEntry::operator== logic with proper parentheses grouping - Add null pointer safety in DataFile::Type() for non-partitioned tables - Change partition field type validation from list to struct in manifest reader - Support empty partition structs for non-partitioned tables (n_children == 0) - Update test bounds values to match actual manifest file data This resolves issues with non-partitioned table support and fixes critical bugs in object comparison and type validation.
HeartLinked
force-pushed
the
manifest-reader-v2-fixes
branch
from
a2bb3cb to
4be162f
Compare
wgtmac
requested changes
Aug 17, 2025
wgtmac
approved these changes
Aug 19, 2025
dongxiao1198
approved these changes
Aug 19, 2025
Xuanwo
approved these changes
Aug 19, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.